On Thu, 2023-11-30 at 09:03 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 30/11/2023 02:51, Chunfeng Yun (云春峰) wrote: > >>> 3. How about we revise the description as follows for more > >> precisely? > >>> > >>> mediatek,force-mode: > >>> description: > >>> The force mode is used to manually switch the shared PHY > mode > >>> between USB and PCIe. When force-mode is set, the USB 3.0 > mode > >>> will be selected. This is typically required for older SoCs > >>> that do not automatically manage PHY mode switching. > >>> For newer SoCs that support it, it is preferable to use the > >>> "mediatek,syscon-type" property instead. > >>> type: boolean > >> > >> Again, what is force-mode? > > Our DE describe this behavior as force-mode, as you see, the driver > > What is "DE"? Hardware designer > > > power down controller and reset pipe to set the mode directly we > want, > > So force-mode is driver behavior? hardware supported, need software to set some registers > > > but usually the phy controller switch to the mode automatically > > according to the external signal, e.g. trapping pin, efuse etc. > > > >> It looks like you wrote bindings for the > >> driver behavior. Bindings describe hardware, not how the driver > >> should > >> behave. The property might be reasonable, but you must describe > here > >> hardware characteristics/issue/etc. > > You must address this, in such case. OK, I'll modify the description Thanks > > > > Best regards, > Krzysztof >
