Hi, thank you for your review! On Fri, Jan 16, 2015 at 1:19 AM, Heiko Stübner <heiko@xxxxxxxxx> wrote: >> + vcc_sata: sata-regulator { >> + compatible = "regulator-fixed"; >> + enable-active-high; >> + gpio = <&gpio4 22 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&sata_pwr>; >> + regulator-name = "usb_5v"; > > why is it named "usb_5v"? it's came from schematic. I think it follows same rule as "vcc_host { regulator-name = "host-pwr"; }" in rk3188-radxarock.dts. I'll include rest of your comments in v2. Regards, -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html