Hi, Mark >> + >> +Required properties: >> +- compatible: must be "sprd,sc9836-uart" >> +- reg: offset and length of the register set for the device >> +- interrupts: exactly one interrupt specifier >> +- clocks: phandles to input clocks. > > The order and relevance of each should be specified. If you have > multiple clocks I would strongly recommend you use clock-names to > distinguish them. > Thank you for the recommendation. but, since we haven't made the clock driver ready, for this initial commit, we just let 4 UARTs share a single fixed 26 MHz clock source. we'll do like you've recommended when we will submit the clock driver in the future. Best regards, Chunyan > Otherwise this looks fine. > > Mark. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
