Hi Zhi, On Fri, Dec 08, 2023 at 02:07:36AM +0000, Zhi Mao (毛智) wrote: > On Thu, 2023-12-07 at 17:44 +0000, Conor Dooley wrote: > > On Thu, Dec 07, 2023 at 01:30:35PM +0100, Krzysztof Kozlowski wrote: > > > On 07/12/2023 12:34, Sakari Ailus wrote: > > > > > + ret = gc08a3_parse_fwnode(dev); > > > > > + if (ret) > > > > > + return ret; > > > > > + > > > > > + gc08a3 = devm_kzalloc(dev, sizeof(*gc08a3), > > > > > GFP_KERNEL); > > > > > + if (!gc08a3) > > > > > + return -ENOMEM; > > > > > + > > > > > + gc08a3->dev = dev; > > > > > + > > > > > + gc08a3->xclk = devm_clk_get(dev, NULL); > > > > > + if (IS_ERR(gc08a3->xclk)) > > > > > + return dev_err_probe(dev, PTR_ERR(gc08a3- > > > > > >xclk), > > > > > + "failed to get > > > > > xclk\n"); > > > > > + > > > > > + ret = clk_set_rate(gc08a3->xclk, > > > > > GC08A3_DEFAULT_CLK_FREQ); > > > > > > > > Please see: > > > > <URL: > > > > https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#devicetree> > > > > ;. > > > > > > > > > Oh, that's cool it was documented! > > > > > > The canonical link would be: > > > > https://www.kernel.org/doc/html/latest/driver-api/media/camera-sensor.html#devicetree > > > > I believe this is that answer to the "why are these needed" that I > > asked > > on the previous version and never got a response to. Instead, they > > were > > just removed from the binding etc. > > About "assigned-clocks" & "assigned-clock-rates" in v1 patch, as they > are not used in sensor driver, I have removed them in sensor dts- > bindind file. And "clock-names" & "clock-frequency" are also the same, > they will be removed in next version. Ack. You should only need "clocks" there, indeed. -- Regards, Sakari Ailus
