On 27/11/2023 01:38, yuji2.ishikawa@xxxxxxxxxxxxx wrote: > Hello Hans, > Thank you for the review. > >> -----Original Message----- >> From: Hans Verkuil <hverkuil@xxxxxxxxx> >> Sent: Tuesday, November 14, 2023 5:41 PM >> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) >> <yuji2.ishikawa@xxxxxxxxxxxxx>; Laurent Pinchart >> <laurent.pinchart@xxxxxxxxxxxxxxxx>; Mauro Carvalho Chehab >> <mchehab@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof >> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley >> <conor+dt@xxxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ >> ＯＳＴ) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> >> Cc: linux-media@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v9 5/5] MAINTAINERS: Add entries for Toshiba Visconti >> Video Input Interface >> >> On 12/10/2023 09:13, Yuji Ishikawa wrote: >>> Added entries for visconti Video Input Interface driver, including; >>> * device tree bindings >>> * source files >>> * documentation files >>> >>> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> >>> --- >>> Changelog v2: >>> - no change >>> >>> Changelog v3: >>> - added entry for driver API documentation >>> >>> Changelog v4: >>> - added entry for header file >>> >>> Changelog v5: >>> - no change >>> >>> Changelog v6: >>> - update path to VIIF driver source files >>> >>> Changelog v7: >>> - no change >>> >>> Changelog v8: >>> - rename bindings description file >>> >>> Changelog v9: >>> - no change >>> >>> MAINTAINERS | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS index >>> eaa1a28a9d54..6035f711b3fb 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -2902,17 +2902,21 @@ F: >> Documentation/devicetree/bindings/arm/toshiba.yaml >>> F: >> Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.y >> aml >>> F: >> Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pismu.y >> aml >>> F: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml >>> +F: >> Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yam >> l >>> F: >> Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.ya >> ml >>> F: Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml >>> F: >> Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.y >> aml >>> F: >> Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt. >> yaml >>> +F: Documentation/driver-api/media/drivers/visconti-viif.rst >>> F: arch/arm64/boot/dts/toshiba/ >>> F: drivers/clk/visconti/ >>> F: drivers/gpio/gpio-visconti.c >>> +F: drivers/media/platform/toshiba/visconti/ >>> F: drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c >>> F: drivers/pci/controller/dwc/pcie-visconti.c >>> F: drivers/pinctrl/visconti/ >>> F: drivers/watchdog/visconti_wdt.c >>> +F: include/uapi/linux/visconti_viif.h >>> N: visconti >> >> This is a bit odd: it adds the driver to an existing entry, but you do not add >> yourself as maintainer. Typically a large driver like this one will have its own >> entry. >> >> At minimum I need an Acked-by from Nobuhiro Iwamatsu for this change. But I >> think it might be better to make a separate entry for this driver. Up to you, >> though. > > I'll make a separate entry for Visconti VIIF driver. > I talked it over with Iwamatsu-san and he agreed. > I need Acked-by tag from him at v10 patch submission; is it a correct understanding? Yes, that's correct. Regards, Hans > >> >> Regards, >> >> Hans >> >>> >>> ARM/UNIPHIER ARCHITECTURE > > Regards, > Yuji
