On 04/12/2023 13:33, Keith Zhao wrote: > StarFive SoCs JH7110 display system: > dc controller, hdmi controller, > encoder, vout syscon. Nothing improved here. > > add the path of yaml file in MAINTAINERS Neither here - still these are not proper sentences and wrapping is wrong. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Keith Zhao <keith.zhao@xxxxxxxxxxxxxxxx> > --- > .../starfive/starfive,display-subsystem.yaml | 104 ++++++++++++++++ > .../starfive/starfive,dsi-encoder.yaml | 92 ++++++++++++++ > .../starfive/starfive,jh7110-dc8200.yaml | 113 ++++++++++++++++++ > .../starfive/starfive,jh7110-inno-hdmi.yaml | 82 +++++++++++++ > .../soc/starfive/starfive,jh7110-syscon.yaml | 1 + > MAINTAINERS | 7 ++ > 6 files changed, 399 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.yaml > create mode 100644 Documentation/devicetree/bindings/display/starfive/starfive,dsi-encoder.yaml > create mode 100644 Documentation/devicetree/bindings/display/starfive/starfive,jh7110-dc8200.yaml > create mode 100644 Documentation/devicetree/bindings/display/starfive/starfive,jh7110-inno-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.yaml b/Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.yaml > new file mode 100644 > index 000000000000..d5ebdba3fb36 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/starfive/starfive,display-subsystem.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive JH7110 Soc Display SubSystem > + > +maintainers: > + - Keith Zhao <keith.zhao@xxxxxxxxxxxxxxxx> > + - ShengYang Chen <shengyang.chen@xxxxxxxxxxxxxxxx> > + > +description: > + This is the bindings documentation for the JH7110 Soc Display Subsystem that Drop "This is the bindings documentation for " because it is obvious. It cannot be anything else. > + includes front-end video data capture, display controller and display > + interface. such as HDMI and MIPI. > + > + JH7110 display pipeline have several components as below description, > + multi display controllers and corresponding physical interfaces. > + For different display scenarios, pipe0 and pipe1 maybe binding to different > + encoder. for example, > + > + pipe0 binding to HDMI for primary display, > + pipe1 binding to DSI for external display. > + > + +------------------------------+ > + | | > + | | > + +----+ | +-------------------+ | +-------+ +------+ +------+ > + | +----->+ dc controller 0 +--->----->+HDMICtl| ->+ PHY +-->+PANEL0+ > + |AXI | | +-------------------+ | +-------+ +------+ +------+ > + | | | | > + | | | | > + | | | | > + | | | | > + |APB | | +-------------------+ +---------+ +------+ +-------+ > + | +----->+ dc controller 1 +--->---->+ dsiTx +--->+DPHY +->+ PANEL1+ > + | | | +-------------------+ +---------+ +------+ +-------+ > + +----+ | | > + +------------------------------+ > + > + > +properties: > + compatible: > + const: starfive,display-subsystem > + > + clocks: > + items: > + - description: Clock for display system noc bus. > + - description: Core clock for display controller. > + - description: Clock for axi bus to access ddr. > + - description: Clock for ahb bus to R/W the phy regs. > + > + clock-names: > + items: > + - const: noc_bus > + - const: dc_core > + - const: axi_core > + - const: ahb > + > + resets: > + items: > + - description: Reset for axi bus. > + - description: Reset for ahb bus. > + - description: Core reset of display controller. > + > + reset-names: > + items: > + - const: axi > + - const: ahb > + - const: core > + > + ports: > + $ref: /schemas/types.yaml#/definitions/phandle-array NAK, you just ignored my comments. More than once in this patchset. I stop review. You must implement entire feedback or respond to it. Especially when ignoring feedback results in buggy code. Best regards, Krzysztof
