Re: [PATCH v2 4/4] drivers: clk: renesas: enable all clocks which is assinged to non Linux system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob

Thank you for reviewing the patch.

> > +static int __init cpg_mssr_reserved_init(struct cpg_mssr_priv *priv,
> > +					 const struct cpg_mssr_info *info)
> > +{
> > +	struct device_node *root = of_find_node_by_path("/soc");
> 
> 'root' is '/', so I find this slightly confusing.
(snip)
> > +	 *	scif5: serial@e6f30000 {
> > +	 *		...
> > +	 * =>		clocks = <&cpg CPG_MOD 202>,
> > +	 *			 <&cpg CPG_CORE R8A7795_CLK_S3D1>,
> > +	 *			 <&scif_clk>;
> > +	 *			 ...
> > +	 *		 status = "reserved";
> > +	 *	};
> > +	 */
> > +	for_each_reserved_child_of_node(root, node) {
> 
> Don't you really want to find all reserved nodes in the DT rather than
> just child nodes of a single node?

The all devices which we need to check (and ignore the clock) in this
driver is defined under /soc for now.


Thank you for your help !!

Best regards
---
Kuninori Morimoto




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux