Re: [PATCH 1/2] dt-bindings: adi,ad5791.yaml: Add support for controlling RBUF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/11/2023 11:11, Nuno Sá wrote:
> On Tue, 2023-11-28 at 10:33 +0100, Krzysztof Kozlowski wrote:
>> On 27/11/2023 16:55, Nuno Sa via B4 Relay wrote:
>>> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
>>>
>>
>> Subject: drop ".yaml"
> 
> Will do...
> 
>>
>>> This patch adds support for an external amplifier to be connected in a
>>
>> Please do not use "This commit/patch", but imperative mood. See longer
>> explanation here:
>> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> ack...
> 
>>
>>> gain of two configuration.
>>>
>>> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
>>> Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
>>> b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
>>> index 3a84739736f6..c81285d84db7 100644
>>> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
>>> @@ -26,6 +26,11 @@ properties:
>>>    vdd-supply: true
>>>    vss-supply: true
>>>  
>>> +  adi,rbuf-gain2-en:
>>> +    description: Specify to allow an external amplifier to be connected in
>>> a
>>> +      gain of two configuration.
>>
>> I don't understand this. Without this property external amplifier is not
>> allowed to be connected? This sounds like some policy, but should rather
>> focus on hardware.
>>
> 
> Well, this really translates in a different configuration in the device. If this
> is set then the device is configured to allow an external amplifier to be
> connected in a gain of two configuration which depends on the HW setup you want
> the chip to be.
> 
> The description already states pretty much what the datasheet says. So while I
> understand it's a fair question from you (you don't have the time to check all
> datasheets for reviews you do), I'm not sure there's much more to add into the
> description of the property.
> 

OK, it's fine there. With earlier fixes:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux