On 27/11/2023 16:55, Nuno Sa via B4 Relay wrote: > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > Subject: drop ".yaml" > This patch adds support for an external amplifier to be connected in a Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > gain of two configuration. > > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml > index 3a84739736f6..c81285d84db7 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml > @@ -26,6 +26,11 @@ properties: > vdd-supply: true > vss-supply: true > > + adi,rbuf-gain2-en: > + description: Specify to allow an external amplifier to be connected in a > + gain of two configuration. I don't understand this. Without this property external amplifier is not allowed to be connected? This sounds like some policy, but should rather focus on hardware. Best regards, Krzysztof
