On 27/11/2023 22:11, Roland Hieber wrote: > From: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > Add DTSI file of Variscite VAR-SOM-MX7 System on Module in a basic > version. While we don't have a VAR-MX7 development board at hand, we > will use this DTSI as base for a custom board in a later commit. > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > Co-developed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Signed-off-by: Roland Hieber <rhi@xxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/nxp/imx/imx7d-var-som-mx7.dtsi | 607 +++++++++++++++++++++++ > 1 file changed, 607 insertions(+) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-var-som-mx7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7d-var-som-mx7.dtsi > new file mode 100644 > index 000000000000..29b9b9305b81 > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/imx/imx7d-var-som-mx7.dtsi > @@ -0,0 +1,607 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2015 Freescale Semiconductor, Inc. > + * Copyright (C) 2016-2017 Variscite Ltd. > + * Copyright (C) 2022 Philipp Zabel, Pengutronix > + * Copyright (C) 2022 Roland Hieber, Pengutronix > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <dt-bindings/input/input.h> > +#include "imx7d.dtsi" > + > +/ { > + model = "Variscite i.MX7 Dual VAR-SOM-MX7"; > + compatible = "variscite,var-som-mx7", "fsl,imx7d"; You claim this was validated, but I don't see anywhere the binding. It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof