On 28/11/2023 01:58, Andre Przywara wrote: > From: Martin Botka <martin.botka@xxxxxxxxxxxxxx> > > This controller is similar to the H6, but covers four sensors and uses > slightly different calibration methods. > Also the H616 requires to poke a bit in the SYS_CFG register range for > correct operation, so add a "syscon" phandle property to point there. > > Signed-off-by: Martin Botka <martin.botka@xxxxxxxxxxxxxx> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > --- > .../thermal/allwinner,sun8i-a83t-ths.yaml | 30 ++++++++++++------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > index fbd4212285e28..95a6ab9a5889b 100644 > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > @@ -20,6 +20,7 @@ properties: > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > - allwinner,sun50i-h6-ths > + - allwinner,sun50i-h616-ths > > clocks: > minItems: 1 > @@ -63,6 +64,7 @@ allOf: > enum: > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h6-ths > + - allwinner,sun50i-h616-ths > > then: > properties: > @@ -80,6 +82,18 @@ allOf: > clock-names: > minItems: 2 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h616-ths > + > + then: > + properties: > + syscon: Nope, there is no such property. First of all, properties must be defined in top level. Second of all - this is exactly the example I used for my talk. Two times. > + maxItems: 1 > + description: phandle to syscon device allowing access to SYS_CFG registers You must also say what is the purpose. Drop redundant parts like "phandle to syscon device allowing access" and explain what is the hardware. Best regards, Krzysztof
