On Fri, Nov 24, 2023 at 10:09 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Fri, Oct 13, 2023 at 07:02:28AM +0800, Chen-Yu Tsai wrote: > > Add entries for MT8186 based Tentacruel / Tentacool Chromebooks. The two > > are based on the same board design: the former is a convertible device > > with a touchscreen, stylus, and some extra buttons; the latter is a > > clamshell device and lacks these additional features. > > > > The two devices both have two variants. The difference is a second > > source touchpad controller that shares the same address as the original, > > but is incompatible. > > > > The extra SKU IDs for the Tentacruel devices map to different sensor > > components attached to the Embedded Controller. These are not visible > > to the main processor. > > > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > I had a chat with Doug at Plumbers about the limitations of your > firmware. As a result, I am fine with acking this if you switch the > order of the sku compatibles to be in descending order. Thank you for taking the effort to understand our weird firmware implementation. And a thank you to Doug for discussing this. I'll send out the next version shortly. > The firmware can handle that, right? Yes. The firmware basically takes a list of machine compatibles, and runs them against all the DTs it has with of_machine_is_compatible(). Thanks ChenYu > > Cheers, > Conor. > > > --- > > .../devicetree/bindings/arm/mediatek.yaml | 26 +++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > index 60337b439744..aa7e6734b336 100644 > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > @@ -206,6 +206,32 @@ properties: > > - enum: > > - mediatek,mt8183-pumpkin > > - const: mediatek,mt8183 > > + - description: Google Tentacruel (ASUS Chromebook CM14 Flip CM1402F) > > + items: > > + - const: google,tentacruel-sku262144 > > + - const: google,tentacruel-sku262145 > > + - const: google,tentacruel-sku262146 > > + - const: google,tentacruel-sku262147 > > + - const: google,tentacruel > > + - const: mediatek,mt8186 > > + - description: Google Tentacruel (ASUS Chromebook CM14 Flip CM1402F) > > + items: > > + - const: google,tentacruel-sku262148 > > + - const: google,tentacruel-sku262149 > > + - const: google,tentacruel-sku262150 > > + - const: google,tentacruel-sku262151 > > + - const: google,tentacruel > > + - const: mediatek,mt8186 > > + - description: Google Tentacool (ASUS Chromebook CM14 CM1402C) > > + items: > > + - const: google,tentacruel-sku327681 > > + - const: google,tentacruel > > + - const: mediatek,mt8186 > > + - description: Google Tentacool (ASUS Chromebook CM14 CM1402C) > > + items: > > + - const: google,tentacruel-sku327683 > > + - const: google,tentacruel > > + - const: mediatek,mt8186 > > - items: > > - enum: > > - mediatek,mt8186-evb > > -- > > 2.42.0.655.g421f12c284-goog > >
