On 25.11.2023 16:04, Bryan O'Donoghue wrote: > On 25/11/2023 13:04, Konrad Dybcio wrote: >> Enable the QCA bluetooth on RB2. It identifies like the following: >> >> Bluetooth: hci0: QCA Product ID :0x0000000a >> Bluetooth: hci0: QCA SOC Version :0x40020150 >> Bluetooth: hci0: QCA ROM Version :0x00000201 >> Bluetooth: hci0: QCA Patch Version:0x00000001 >> Bluetooth: hci0: QCA controller version 0x01500201 >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> --- [...] >> + >> + rx-pins { >> + pins = "gpio11"; >> + function = "gpio"; >> + bias-pull-up; >> + }; >> + }; >> + > > My reading of downstream has all of these pins drive-strength = <2>. Right, I'll fix it up. > > >> lt9611_rst_pin: lt9611-rst-state { >> pins = "gpio41"; >> function = "gpio"; >> @@ -508,6 +567,26 @@ sdc2_card_det_n: sd-card-det-n-state { >> }; >> }; >> +&uart3 { >> + interrupts-extended = <&intc GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, >> + <&tlmm 11 IRQ_TYPE_LEVEL_HIGH>; >> + pinctrl-0 = <&uart3_default>; >> + pinctrl-1 = <&uart3_sleep>; >> + pinctrl-names = "default", "sleep"; >> + status = "okay"; >> + >> + bluetooth { >> + compatible = "qcom,wcn3988-bt"; >> + >> + vddio-supply = <&vreg_l9a_1p8>; >> + vddxo-supply = <&vreg_l16a_1p3>; >> + vddrf-supply = <&vreg_l17a_1p3>; >> + vddch0-supply = <&vreg_l23a_3p3>; >> + enable-gpios = <&tlmm 87 GPIO_ACTIVE_HIGH>; >> + max-speed = <3200000>; >> + }; >> +}; > > Does firmware name not matter here ? The driver figures it out, see drivers/bluetooth/btqca.c : qca_uart_setup() Konrad