On Thu, Nov 16, 2023 at 03:01:35PM +0100, Kory Maincent wrote: > Introduce an enumeration to define PSE types (PoE or PoDL), > utilizing a bitfield for potential future support of both types. > Include 'pse_get_types' helper for external access to PSE type info > > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx> ... > diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h ... > @@ -133,6 +150,11 @@ static inline int pse_ethtool_set_config(struct pse_control *psec, > return -ENOTSUPP; > } > > +static u32 pse_get_types(struct pse_control *psec) Hi Kory, a minor nit from my side: as this is a function in a header file, it should be static inline > +{ > + return PSE_UNKNOWN; > +} ...