On 11/24/2023 5:53 PM, Russell King (Oracle) wrote:
On Fri, Nov 24, 2023 at 05:47:04PM +0800, Jie Luo wrote:
On 11/23/2023 8:01 PM, Russell King (Oracle) wrote:
On Thu, Nov 23, 2023 at 06:57:59PM +0800, Jie Luo wrote:
On 11/21/2023 7:52 PM, Russell King (Oracle) wrote:
Ultimately, you will need a way to use inband signalling with Cisco
SGMII for 10M/100M/1G speeds, and then switch to 2500base-X when
operating at 2.5G speeds, and that is done via the PHY driver
updating phydev->interface.
What we do need is some way for the PHY to also tell the PCS/MAC
whether inband should be used. This is something I keep bringing up
and now that we have PCS drivers revised to use the value from
phylink_pcs_neg_mode() _and_ a consistent implementation amongst them
we can now think about signalling to PCS drivers whether inband mode
needs to be turned off when switching between modes.
Yes, we can switch the interface mode according to the current link
speed in the pcs driver.
but the issue is that the phy-mode i specified for the PHYLINK,
if phy-mode is sgmii, the support capability is limited to maximum
capability 1G during the PHYLINK setup and i can't configure it to 2.5G
dynamically, if the phy-mode is 2500base-x, then PHY capability will
be modified to only support 2.5G, other speeds can't be linked up.
So you need my patches that add "possible_interfaces" to phylib so you
can tell phylink that you will be switching between SGMII and
2500base-X. Please see the RFC posting of those patches I sent
yesterday and try them out - you will need to modify your phylib
driver to fill in phydev->possible_interfaces.
Your patches work on my board, thanks Russell.
Please can you reply to the covering email for that series giving your
tested-by? Thanks.
Ok.
