On 11/24/2023 3:43 PM, Johan Hovold wrote:
On Fri, Nov 24, 2023 at 02:30:56PM +0530, Krishna Kurapati PSSNV wrote:
I didn't add missing interrupts on sc8280xp because I see that current
interrupts present are working fine (I see ADB working and wakeup
working as well), but the interrupt vector numbers are off by "1"
between hs specifics and DT (both upstream and downstream). Will sort it
out and clean that target up later.
Which interrupt numbers are off by one here?
Sorry for mentioning that it is wrong. The DT entries are right and it
is working on upstream.
Thanks for clarifying.
[1]: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=803412
I took a quick look at the series, and it looks like this will
eventually clean things up a lot. We should probably define a generic
order for the interrupts with the sometimes optional SS interrupts last.
Side note: It looks like the threading in that series is broken.
Consider using git-send-email for sending series as it takes care of
things like that.
Usually I do git send-email for the whole out folder where the patches
are present, but linux-usb list is common to all the patches in that
case, even the DT ones. So to avoid that and to send patches to only
relavant mailing lists, I did git send email individually on each patch
which might have caused this issue.
I'd suggest that you just send two separate series, one with binding and
driver updates, which will eventually be merged by Greg, and one with
the devicetree changes, which goes through Bjorn's tree.
It's good if you could add a link to the binding series in the cover
letter of the devicetree changes as they are of course going to be quite
closely related and need to be reviewed in parallel.
Thanks for this pointer. So for Multiport, can I do it this way:
1. Core bindings and Core driver changes in one series. Now that we
finalized we don't be adding the ctrl_irq[1] as discussed on:
https://lore.kernel.org/all/ZU33uWpStIobzyd6@xxxxxxxxxxxxxxxxxxxx/.
2. QC bindings and QC driver changes for Multiport to be pushed after we
clean up the current driver and DT's (an effort which is going on
currently).
Regards,
Krishna,
