Hi Tzuyi, On Thu, Nov 16, 2023 at 12:14 PM Tzuyi Chang <tychang@xxxxxxxxxxx> wrote: > This driver enables configuration of GPIO direction, GPIO values, GPIO > debounce settings and handles GPIO interrupts. > > Signed-off-by: Tzuyi Chang <tychang@xxxxxxxxxxx> Apart from the missing kerneldoc that the autobuilder is complaining about this looks good to me. If you fix the kerneldoc: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij