Hi Geert, Thanks for your review. On 2023-11-21 09:00:41 +0100, Geert Uytterhoeven wrote: > On Tue, Nov 21, 2023 at 8:45 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 20/11/2023 17:07, Niklas Söderlund wrote: > > > Add bindings for Renesas R-Car Ethernet TSN End-station IP. The RTSN > > > device provides Ethernet network. > > > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/renesas,ethertsn.yaml > > > @@ -0,0 +1,133 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/net/renesas,ethertsn.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Renesas Ethernet TSN End-station > > > + > > > +maintainers: > > > + - Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> > > > + > > > +description: > > > + The RTSN device provides Ethernet network using a 10 Mbps, 100 Mbps, or 1 > > > + Gbps full-duplex link via MII/GMII/RMII/RGMII. Depending on the connected PHY. > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > + - items: > > > > Drop items. > > > > I assume you have oneOf above because you predict this will grow with > > entries with fallbacks? If not, drop. > > > > > + - enum: > > > + - renesas,ethertsn-r8a779g0 # R-Car V4H > > renesas,r8a779g0-ethertsn > > R-Car S4 also has EtherTSN. > Is it identical, so it makes sense to add a renesas,rcar-gen4-ethertsn > fallback? Thanks. Will address both suggestions in v2. > > > > + renesas,rx-internal-delay: > > > + type: boolean > > > + description: > > > + Enable internal Rx clock delay, typically 1.8ns. > > > > Why this is bool, not delay in ns? > > Why this is property of a board (not SoC)? > > Standard property is rx-internal-delay-ps. > > > > + > > > + renesas,tx-internal-delay: > > > + type: boolean > > > + description: > > > + Enable internal Tx clock delay, typically 2.0ns. > > > > Same questions. > > Standard property is tx-internal-delay-ps. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kind Regards, Niklas Söderlund
