Hi Pavel, thanks for the review. On Sat, Nov 11, 2023 at 08:23:13PM +0100, Pavel Machek wrote: > Hi! > > > Introduction of the Galaxy Core GC2145 XVGA CMOS camera sensor. > > > diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml > > new file mode 100644 > > index 000000000000..94d194cf5452 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/galaxycore,gc2145.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Galaxy Core 1/5'' UXGA CMOS Image Sensor > > + > > +maintainers: > > + - Alain Volmat <alain.volmat@xxxxxxxxxxx> > > + > > +description: > > + The Galaxy Core GC2145 is a high quality 2 Mega CMOS image sensor, for mobile > > I'd drop "high quality" and add "pixel". Ok, done in v4. > > > + phone camera applications and digital camera products. GC2145 incorporates a > > + 1616V x 1232H active pixel array, on-chip 10-bit ADC, and image signal > > + processor. It is programmable through an I2C interface. Image data is sent > > + either through a parallel interface or through MIPI CSI-2. > > Short note what the on-board ISP can do might be welcome here. Ok, done in v4. > > Best regards, > Pavel > -- > People of Russia, stop Putin before his war on Ukraine escalates. Regards, Alain
