On 11/17/23 10:37, Geert Uytterhoeven wrote: > On Thu, Nov 16, 2023 at 6:55 PM Conor Dooley <conor@xxxxxxxxxx> wrote: >> On Thu, Nov 16, 2023 at 03:15:46PM +0200, Cristian Ciocaltea wrote: >>> On 10/30/23 00:53, Cristian Ciocaltea wrote: >>>> On 10/29/23 20:46, Andrew Lunn wrote: >>>>> On Sun, Oct 29, 2023 at 06:27:12AM +0200, Cristian Ciocaltea wrote: >>>>>> The BeagleV Starlight SBC uses a Microchip KSZ9031RNXCA PHY supporting >>>>>> RGMII-ID. >>>>>> >>>>>> TODO: Verify if manual adjustment of the RX internal delay is needed. If >>>>>> yes, add the mdio & phy sub-nodes. >>>>> >>>>> Please could you try to get this tested. It might shed some light on >>>>> what is going on here, since it is a different PHY. >>>> >>>> Actually, this is the main reason I added the patch. I don't have access >>>> to this board, so it would be great if we could get some help with testing. >>> >>> @Emil, @Conor: Any idea who might help us with a quick test on the >>> BeagleV Starlight board? >> >> I don't have one & I am not sure if Emil does. Geert (CCed) should have > > I believe Esmil has. > >> one though. Is there a specific test you need to have done? > > I gave it a try, on top of latest renesas-drivers[1]. > > ------------[ cut here ]------------ > simple-pm-bus soc: device non-coherent but no non-coherent operations supported > WARNING: CPU: 0 PID: 1 at arch/riscv/mm/dma-noncoherent.c:140 > arch_setup_dma_ops+0x7e/0xa2 > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted > 6.7.0-rc1-starlight-01489-g995c2f0b8b7e #259 > Hardware name: BeagleV Starlight Beta (DT) > epc : arch_setup_dma_ops+0x7e/0xa2 > ra : arch_setup_dma_ops+0x7e/0xa2 > epc : ffffffff8000d462 ra : ffffffff8000d462 sp : ffffffc800013b90 > gp : ffffffff812d6460 tp : ffffffd880130000 t0 : ffffffff81217238 > t1 : 000000000000002d t2 : 2d2d2d2d2d2d2d2d s0 : ffffffc800013bc0 > s1 : 0000000000000000 a0 : 000000000000004f a1 : 0000000200000020 > a2 : 0000000000000000 a3 : 0000000000000001 a4 : 0000000000000000 > a5 : 0000000000000000 a6 : 0000000000000000 a7 : 0000000000000030 > s2 : ffffffd880111410 s3 : ffffffff812d712c s4 : 00000000ffffffff > s5 : ffffffffffffffed s6 : ffffffd9fffeb530 s7 : ffffffff80a00d70 > s8 : ffffffff80e3f2c0 s9 : 0000000000000008 s10: ffffffff808000ba > s11: 0000000000000000 t3 : ffffffff812ebb5c t4 : ffffffff812ebb5c > t5 : ffffffff812ebb38 t6 : ffffffff812ebbb7 > status: 0000000200000120 badaddr: ffffffff812d712c cause: 0000000000000003 > [<ffffffff8000d462>] arch_setup_dma_ops+0x7e/0xa2 > [<ffffffff80518cb2>] of_dma_configure_id+0xc4/0x222 > [<ffffffff803ee76e>] platform_dma_configure+0x44/0x4e > [<ffffffff803ec382>] really_probe+0x54/0x20c > [<ffffffff803ec596>] __driver_probe_device+0x5c/0xd0 > [<ffffffff803ec636>] driver_probe_device+0x2c/0xb0 > [<ffffffff803ec7b6>] __driver_attach+0x6e/0x104 > [<ffffffff803ea652>] bus_for_each_dev+0x58/0xa4 > [<ffffffff803ebdc8>] driver_attach+0x1a/0x22 > [<ffffffff803eb7ba>] bus_add_driver+0xd4/0x19e > [<ffffffff803ed476>] driver_register+0x3e/0xd8 > [<ffffffff803ee590>] __platform_driver_register+0x1c/0x24 > [<ffffffff8081db32>] simple_pm_bus_driver_init+0x1a/0x22 > [<ffffffff800020f0>] do_one_initcall+0x38/0x17c > [<ffffffff80801354>] kernel_init_freeable+0x1a8/0x20c > [<ffffffff806b1328>] kernel_init+0x1e/0x112 > [<ffffffff806b891e>] ret_from_fork+0xe/0x1c > ---[ end trace 0000000000000000 ]--- > ------------[ cut here ]------------ > clk-starfive-jh7100 11800000.clock-controller: device non-coherent but > no non-coherent operations supported > WARNING: CPU: 0 PID: 1 at arch/riscv/mm/dma-noncoherent.c:140 > arch_setup_dma_ops+0x7e/0xa2 > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G S > 6.7.0-rc1-starlight-01489-g995c2f0b8b7e #259 > Hardware name: BeagleV Starlight Beta (DT) > epc : arch_setup_dma_ops+0x7e/0xa2 > ra : arch_setup_dma_ops+0x7e/0xa2 > epc : ffffffff8000d462 ra : ffffffff8000d462 sp : ffffffc800013b70 > gp : ffffffff812d6460 tp : ffffffd880130000 t0 : ffffffff81217f48 > t1 : 000000000000002d t2 : 2d2d2d2d2d2d2d2d s0 : ffffffc800013ba0 > s1 : 0000000000000000 a0 : 000000000000006b a1 : 0000000200000020 > a2 : 0000000000000000 a3 : 0000000000000001 a4 : 0000000000000000 > a5 : 0000000000000000 a6 : 0000000000000000 a7 : 0000000000000030 > s2 : ffffffd880112410 s3 : ffffffff812d712c s4 : 0000000fffffffff > s5 : 0000000000000000 s6 : ffffffd9fffed3c8 s7 : ffffffff80a00d70 > s8 : ffffffff80e3f2c0 s9 : 0000000000000008 s10: ffffffff808000ba > s11: 0000000000000000 t3 : ffffffff812ec564 t4 : ffffffff812ec564 > t5 : ffffffff812ec540 t6 : ffffffff812ec5db > status: 0000000200000120 badaddr: ffffffd880130008 cause: 0000000000000003 > [<ffffffff8000d462>] arch_setup_dma_ops+0x7e/0xa2 > [<ffffffff80518cb2>] of_dma_configure_id+0xc4/0x222 > [<ffffffff803ee76e>] platform_dma_configure+0x44/0x4e > [<ffffffff803ec382>] really_probe+0x54/0x20c > [<ffffffff803ec596>] __driver_probe_device+0x5c/0xd0 > [<ffffffff803ec636>] driver_probe_device+0x2c/0xb0 > [<ffffffff803ec7b6>] __driver_attach+0x6e/0x104 > [<ffffffff803ea652>] bus_for_each_dev+0x58/0xa4 > [<ffffffff803ebdc8>] driver_attach+0x1a/0x22 > [<ffffffff803eb7ba>] bus_add_driver+0xd4/0x19e > [<ffffffff803ed476>] driver_register+0x3e/0xd8 > [<ffffffff803ee6ce>] __platform_driver_probe+0x40/0x9c > [<ffffffff8081eb80>] clk_starfive_jh7100_driver_init+0x22/0x2a > [<ffffffff800020f0>] do_one_initcall+0x38/0x17c > [<ffffffff80801354>] kernel_init_freeable+0x1a8/0x20c > [<ffffffff806b1328>] kernel_init+0x1e/0x112 > [<ffffffff806b891e>] ret_from_fork+0xe/0x1c > ---[ end trace 0000000000000000 ]--- > CCACHE: DataFail @ 0x00000000.7FEB8930 > CCACHE: 2 banks, 16 ways, sets/bank=1024, bytes/block=64 > CCACHE: Index of the largest way enabled: 0 > ------------[ cut here ]------------ > jh7100-reset 11840000.reset-controller: device non-coherent but no > non-coherent operations supported > WARNING: CPU: 0 PID: 1 at arch/riscv/mm/dma-noncoherent.c:140 > arch_setup_dma_ops+0x7e/0xa2 > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G S > 6.7.0-rc1-starlight-01489-g995c2f0b8b7e #259 > Hardware name: BeagleV Starlight Beta (DT) > epc : arch_setup_dma_ops+0x7e/0xa2 > ra : arch_setup_dma_ops+0x7e/0xa2 > epc : ffffffff8000d462 ra : ffffffff8000d462 sp : ffffffc800013b70 > gp : ffffffff812d6460 tp : ffffffd880130000 t0 : ffffffff81218d60 > t1 : 000000000000002d t2 : 2d2d2d2d2d2d2d2d s0 : ffffffc800013ba0 > s1 : 0000000000000000 a0 : 0000000000000064 a1 : 0000000200000020 > a2 : 0000000000000000 a3 : 0000000000000001 a4 : 0000000000000000 > a5 : 0000000000000000 a6 : 0000000000000000 a7 : 0000000000000030 > s2 : ffffffd880112c10 s3 : ffffffff812d712c s4 : 0000000fffffffff > s5 : 0000000000000000 s6 : ffffffd9fffed7a8 s7 : ffffffff80a00d70 > s8 : ffffffff80e3f2c0 s9 : 0000000000000008 s10: ffffffff808000ba > s11: 0000000000000000 t3 : ffffffff812ed054 t4 : ffffffff812ed054 > t5 : ffffffff812ed030 t6 : ffffffff812ed0c4 > status: 0000000200000120 badaddr: ffffffd880130008 cause: 0000000000000003 > [<ffffffff8000d462>] arch_setup_dma_ops+0x7e/0xa2 > [<ffffffff80518cb2>] of_dma_configure_id+0xc4/0x222 > [<ffffffff803ee76e>] platform_dma_configure+0x44/0x4e > [<ffffffff803ec382>] really_probe+0x54/0x20c > [<ffffffff803ec596>] __driver_probe_device+0x5c/0xd0 > [<ffffffff803ec636>] driver_probe_device+0x2c/0xb0 > [<ffffffff803ec7b6>] __driver_attach+0x6e/0x104 > [<ffffffff803ea652>] bus_for_each_dev+0x58/0xa4 > [<ffffffff803ebdc8>] driver_attach+0x1a/0x22 > [<ffffffff803eb7ba>] bus_add_driver+0xd4/0x19e > [<ffffffff803ed476>] driver_register+0x3e/0xd8 > [<ffffffff803ee6ce>] __platform_driver_probe+0x40/0x9c > [<ffffffff8081f284>] jh7100_reset_driver_init+0x22/0x2a > [<ffffffff800020f0>] do_one_initcall+0x38/0x17c > [<ffffffff80801354>] kernel_init_freeable+0x1a8/0x20c > [<ffffffff806b1328>] kernel_init+0x1e/0x112 > [<ffffffff806b891e>] ret_from_fork+0xe/0x1c > ---[ end trace 0000000000000000 ]--- > CCACHE: DataFail @ 0x00000000.7FEB0830 > CCACHE: DataFail @ 0x00000000.7FEB07F0 > CCACHE: DataFail @ 0x00000000.7FEB07F0 > CCACHE: DataFail @ 0x00000000.7FEB07F0 > CCACHE: DataFail @ 0x00000000.7FEB0830 > CCACHE: DataFail @ 0x00000000.7FEB07F0 > > [...] > > Looks like it needs more non-coherent support before we can test > Ethernet. Hi Geert, Thanks for taking the time to test this! Could you please check if the following are enabled in your kernel config: CONFIG_DMA_GLOBAL_POOL CONFIG_RISCV_DMA_NONCOHERENT CONFIG_RISCV_NONSTANDARD_CACHE_OPS CONFIG_SIFIVE_CCACHE Regards, Cristian > Note that it boots fine into Debian nfsroot when merging Emil's[2] > visionfive branch instead. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/tag/?h=renesas-drivers-2023-11-14-v6.7-rc1 > [2] https://github.com/esmil/linux > > Gr{oetje,eeting}s, > > Geert >
