On Wed, Nov 15, 2023 at 06:28:07PM +0530, Anshul Dalal wrote: > Add bindings for Aosong AGS02MA TVOC sensor. > > The sensor communicates over i2c with the default address 0x1a. > TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > > Datasheet: > https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > Product-Page: > http://www.aosong.com/m/en/products-33.html > > Signed-off-by: Anshul Dalal <anshulusr@xxxxxxxxx> > --- > > Changes for v2: > - Removed device from trivial-devices Your $subject still says "trivial-devices" though, so please fix that in your next submission. > - Added standalone binding with vdd-supply property > --- > .../bindings/iio/chemical/aosong,ags02ma.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > new file mode 100644 > index 000000000000..4a0278c6318c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aosong AGS02MA VOC Sensor > + > +description: | > + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default > + address of 0x1a. > + > + Datasheet: > + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > + > +maintainers: > + - Anshul Dalal <anshulusr@xxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - aosong,ags02ma > + - asair,ags02ma Why do you have two compatibles for the same device? Please document and use only one of these. The aoson website says: "Guangzhou ASAIR Electronic Co., Ltd" so I suspect "asair" is a more apt vendor prefix. Thanks, Conor. > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@1a { > + compatible = "aosong,ags02ma"; > + reg = <0x1a>; > + vdd-supply = <&vdd_regulator>; > + }; > + }; > -- > 2.42.0 >
Attachment:
signature.asc
Description: PGP signature
