On 11/13/23 13:51, Andrew Lunn wrote:
On Mon, Nov 13, 2023 at 05:40:52PM -0300, Fabio Estevam wrote:
From: Fabio Estevam <festevam@xxxxxxx>
The property 'phy-connection-type' can also be used to describe
the interface type between the Ethernet device and the Ethernet PHY
device.
Mark 'phy-mode' as a non required property.
Hi Fabio
What does the driver actually require? Will it error out if neither is
provided?
Maybe we should be changing the condition that one or the other is
required?
'phy-connection-type' is the deprecated version of 'phy-mode' which
of_get_phy_mode() will fall back to if 'phy-mode' is not provided. It
does not appear that stmmac attempts to use anything other than
of_get_phy_mode() therefore would not it be acceptable to update the
relevant .dts file such that it uses 'phy-mode'?
That really should not have a functional impact given that
of_get_phy_mode() has worked that way for a while.
--
Florian
