On 09/11/2023 08:34, Jyan Chou [周芷安] wrote: >>> + priv->m2tmx = >>> + syscon_regmap_lookup_by_phandle(host->dev->of_node, >>> + "realtek,m2tmx"); > >> NAK, for the same reasons I mentioned for other patch. > >> I will keep NAK-ing till you start testing your DTS. > > Sorry, I am not sure whether I modify the correct thing you said. I will add > > realtek,m2tmx in bindings. Upstream a tested DTS. I don't trust that you test it, so I need to see it. Best regards, Krzysztof