Re: [v1 3/3] ASoC: mediatek: mt8188-mt6359: add two amps support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



OK, I'll revise it as soon as possible.

On Tue, Nov 7, 2023 at 4:31 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
>
> Il 07/11/23 04:14, Rui Zhou ha scritto:
> > Support codec rt5682 using two amps.
> >
> > Signed-off-by: Rui Zhou <zhourui@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Can you please change the commit description so that it's clear that you're adding
> the two amps support to the RT5682s variant? As it is right now, it reads like you
> are adding that globally.
>
> ASoC: mediatek: mt8188-mt6359: Enable dual amp for mt8188_rt5682s
>
> After which:
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
> > ---
> >   sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> > index e994faa3556b..917640939621 100644
> > --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> > +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> > @@ -1549,7 +1549,7 @@ static struct mt8188_card_data mt8188_nau8825_card = {
> >
> >   static struct mt8188_card_data mt8188_rt5682s_card = {
> >       .name = "mt8188_rt5682s",
> > -     .quirk = RT5682S_HS_PRESENT,
> > +     .quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP,
> >   };
> >
> >   static struct mt8188_card_data mt8188_es8326_card = {
>
>





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux