Re: [PATCH V3 4/4] arm64: dts: qcom: ipq5018: Add tsens node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



<..>

On 22. 09. 2023. 13:51, Sricharan R wrote:
From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>

IPQ5018 has tsens V1.0 IP with 4 sensors.
There is no RPM, so tsens has to be manually enabled. Adding the tsens
and nvmem node and IPQ5018 has 4 thermal sensors (zones). With the
critical temperature being 120'C and action is to reboot. Adding all
the 4 zones here.

Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
---
   [v3] Ordered the qfprom device node properties as per
        Krzysztof's comments

   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 169 ++++++++++++++++++++++++++
   1 file changed, 169 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 9f13d2dcdfd5..9e28b54ebcbd 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -93,6 +93,117 @@ soc: soc@0 {
           #size-cells = <1>;
           ranges = <0 0 0 0xffffffff>;
+        qfprom: qfprom@a0000 {
+            compatible = "qcom,ipq5018-qfprom", "qcom,qfprom";
Hi,

"qcom,ipq5018-qfprom" needs to be documented in QFPROM bindings first.

   Already posted here [1]. Initially had it in the same series, but kept
   it separately based on review comments.

   [1] https://www.spinics.net/lists/devicetree/msg633408.html

Well, if it's not part of the same series then this addition would
cause a warning as its
undocumented.

I also dont see where is it documented as part of the v2 series.

 Then in that case, will keep it in same series again in V4

Regards,
 Sricharan




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux