В Чт, 02/11/2023 в 10:26 +0100, Krzysztof Kozlowski пишет: > On 02/11/2023 08:49, Viacheslav Bocharov wrote: > > Use meson_gx_socinfo variable for chipid compatible call > > from meson-gx-socinfo driver if available. > > > > So we are back to something like ARMv7 platform/mach-code with > drivers > tightly coupled between subsystems. But it is not 2007 anymore and we > have Devicetree for this. Use it instead. > > What's more, your commit msg does not explain at all why do you need > to > do it. This is some "show" callback, which does not exist in current > code. Adding code in one patch and then changing it, looks like you > add > incomplete or buggy feature. > > Best regards, > Krzysztof > Fair enough. This patch is related to an adjacent one where the socinfo data supplements the result of executing the chipid version 1 function. Indeed, with the introduction of chipid v.2, we now have a second option for obtaining soc info (the first being implemented via register reading). And I'm somewhat contemplative: whether to move the meson-gx- socinfo entirely to the secure monitor or to duplicate the code from there. As a driver, meson-gx-socinfo does not carry practical information apart from outputting status in the boot log, and it cannot be reused without modifications to the driver. -- Viacheslav Bocharov
