On 02/11/2023 08:49, Viacheslav Bocharov wrote: > Use meson_gx_socinfo variable for chipid compatible call > from meson-gx-socinfo driver if available. > So we are back to something like ARMv7 platform/mach-code with drivers tightly coupled between subsystems. But it is not 2007 anymore and we have Devicetree for this. Use it instead. What's more, your commit msg does not explain at all why do you need to do it. This is some "show" callback, which does not exist in current code. Adding code in one patch and then changing it, looks like you add incomplete or buggy feature. Best regards, Krzysztof