Hi Gigi,
> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
>
> Signed-off-by: Eyal Reizer <eyalr@xxxxxx>
> Signed-off-by: bvijay <bvijay@xxxxxx>
> Signed-off-by: Gigi Joseph <gigi.joseph@xxxxxx>
> ---
> drivers/bluetooth/btwilink.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
> index 55c135b..95adec3 100644
> --- a/drivers/bluetooth/btwilink.c
> +++ b/drivers/bluetooth/btwilink.c
> @@ -30,6 +30,7 @@
>
> #include <linux/ti_wilink_st.h>
> #include <linux/module.h>
> +#include <linux/of.h>
>
> /* Bluetooth Driver Version */
> #define VERSION "1.0"
> @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
> return 0;
> }
>
> +static const struct of_device_id btwilink_of_match[] = {
> +{
> + .compatible = "btwilink",
> + },
> + {}
> +};
this formatting is bogus. Please construct it similar to what other drivers are doing.
static const struct .. = {
{ .compatible = ".." },
{ } /* Terminating entry */
};
And add an extra empty line before MODULE_DEVICE_TABLE.
> +MODULE_DEVICE_TABLE(of, btwilink_of_match);
> +
> static int bt_ti_probe(struct platform_device *pdev)
> {
> static struct ti_st *hst;
> @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
> .remove = bt_ti_remove,
> .driver = {
> .name = "btwilink",
> + .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(btwilink_of_match),
> },
> };
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
