Re: [PATCH v1 2/2] iio: light: Add support for APDS9306 Light Sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Subhajit,

It's nice to see the GTS helpers are used (and hopefully helpful). I didn't have the time to go through everything with full focus - so please just tell me if some of my questions are silly :) The comments I marked as 'nit' aren't really important - feel free to use your judgement on them :)

Thank you Matti for the review.
Acknowledging all your comments, updates will be in the next version.
I am glad that you liked it.

GTS helpers are great. It saved me a lot of complex and error prone mathematical calculations and coding.
I was surprised to get consistent Lux values in userspace across all scale ranges which closely matched with
my entry level Lux meter readings after using the GTS implementation. Great work.

Regards,
Subhajit Ghosh




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux