On Wed, Oct 25, 2023 at 04:18:31PM +0200, Krzysztof Kozlowski wrote: > On 25/10/2023 16:11, Conor Dooley wrote: > > On Wed, Oct 25, 2023 at 04:07:31PM +0200, Richard Leitner wrote: > >> On Wed, Oct 25, 2023 at 03:00:01PM +0100, Conor Dooley wrote: > >>> On Wed, Oct 25, 2023 at 10:34:12AM +0000, Richard Leitner wrote: > >>>> The ina238 driver is available since 2021 but lacks a dt-bindings file. > >>>> Therefore add the missing file now. > >>> > >>> Seemingly it is documented in Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > >> > >> Thanks for the feedback. True. So is it fine if it's left there or > >> should it be removed from ti,ina2xxx.yml as this is a separate driver > >> with different properties? > > > > Merging them would seem like the most straightforward thing to do, no? > > Sorry folks, I don't quite get what do you want to merge or move and > why. Drivers are not related to bindings. The point is the compatible is > already documented, so is anything wrong with existing documentation? ina238 is a separate driver which doesn't evaluate the same properties as the ina2xx driver. So I thought it would be reasonable to split those bindings and therefore reflect the drivers capabilities. If it's fine if there are additional properties in the dt-bindings which are not evaluated by the driver then it's of course fine with me to just add the ina327 compatible in ina2xx.yaml. Thanks for the feedback & regards;rl > > Best regards, > Krzysztof >
