On Wed, Oct 25, 2023 at 03:00:01PM +0100, Conor Dooley wrote: > On Wed, Oct 25, 2023 at 10:34:12AM +0000, Richard Leitner wrote: > > The ina238 driver is available since 2021 but lacks a dt-bindings file. > > Therefore add the missing file now. > > Seemingly it is documented in Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml Thanks for the feedback. True. So is it fine if it's left there or should it be removed from ti,ina2xxx.yml as this is a separate driver with different properties? > > Cheers, > Conor. > > > > > Mention Jean Delvare and Guenter Roeck as maintainers as reported by the > > get_maintainer.pl script. > > > > Signed-off-by: Richard Leitner <richard.leitner@xxxxxxxxx> > > --- > > .../devicetree/bindings/hwmon/ti,ina238.yaml | 46 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 47 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml > > new file mode 100644 > > index 000000000000..aba89e5f34b3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/hwmon/ti,ina238.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Texas Instruments INA238 power/voltage monitors > > + > > +maintainers: > > + - Jean Delvare <jdelvare@xxxxxxxx> > > + - Guenter Roeck <linux@xxxxxxxxxxxx> > > + > > +description: | > > + The INA238 is an ultra-precise digital power monitor with a > > + 16-bit delta-sigma ADC specifically designed for current-sensing > > + applications. > > + > > + Datasheets: > > + https://www.ti.com/lit/ds/symlink/ina238.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - ti,ina238 > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + power-sensor@40 { > > + compatible = "ti,ina238"; > > + reg = <0x40>; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 28f91c8a2e1c..13858bd6a3d4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -10271,6 +10271,7 @@ INA238 HARDWARE MONITOR DRIVER > > M: Guenter Roeck <linux@xxxxxxxxxxxx> > > L: linux-hwmon@xxxxxxxxxxxxxxx > > S: Maintained > > +F: Documentation/devicetree/bindings/hwmon/ti,ina238.yaml > > F: drivers/hwmon/ina238.c > > > > INDEX OF FURTHER KERNEL DOCUMENTATION > > > > -- > > 2.40.1 > >