Re: [PATCH v2 5/6] arm64: dts: qcom: starqltechn: disable crypto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/10/2023 16:43, Dzmitry Sankouski wrote:
Disable the crypto block due to it causing an SError in qce_start() on
the starqltechn, which happens upon every boot when cryptomanager tests are
enabled.

Same problem is on Lenovo C630, see
commit 382e3e0eb6a8 ("arm64: dts: qcom: c630: disable crypto due to serror")

Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
Link: https://lore.kernel.org/r/20211105035235.2392-1-steev@xxxxxxxx
Cc: Andy Gross <agross@xxxxxxxxxx>
Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
Cc: Rob Herring <robh+dt@xxxxxxxxxx>
Cc: devicetree@xxxxxxxxxxxxxxx
Cc: linux-arm-msm@xxxxxxxxxxxxxxx

---

Changes in v2:
- none

  arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index f2bc3c412a2f..0e2c7df2baa7 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -504,6 +504,11 @@ touchscreen@48 {
  	};
  };
+&crypto {
+	/* FIXME: qce_start triggers an SError */
+	status = "disable";
+};
+
  /* Modem/wifi*/
  &mss_pil {
  	status = "okay";

Probably another patch that should have Fixes.

BTW when you do "git send-email" please include a "--to=someone@xxxxxxxxxxx" your emails appear with a weird red box that declares "(no To-header on input)<>" in Thunderbird - I guess because you didn't do "git send-email --to="

For preference I do "--to=" for everybody who appears as a maintainer/supporter and "--cc=" to the named mailing lists with myself last.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

---
bod




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux