On Fri, Oct 20, 2023 at 04:25:03PM +0200, Ante Knezic wrote: > Add documentation for selecting reference rmii clock on KSZ88X3 devices > > Signed-off-by: Ante Knezic <ante.knezic@xxxxxxxxxxx> Something in the commit message explaining why a property is needed rather than using the regular old clocks property would be good. Please do that if you re-spin. Otherwise, Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> (and despite the domain, I have nothing to do with switches...) Cheers, Conor. > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > index 41014f5c01c4..624feb1bb9be 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > @@ -72,6 +72,23 @@ properties: > interrupts: > maxItems: 1 > > + microchip,rmii-clk-internal: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Set if the RMII reference clock is provided internally. Otherwise > + reference clock should be provided externally. > + > +if: > + not: > + properties: > + compatible: > + enum: > + - microchip,ksz8863 > + - microchip,ksz8873 > +then: > + properties: > + microchip,rmii-clk-internal: false > + > required: > - compatible > - reg > -- > 2.11.0 >
Attachment:
signature.asc
Description: PGP signature