On 18/10/2023 17:54, Kris Chaplin wrote: > Thank you Krzysztof, > > I shall post v2 tomorrow: > > On 13/10/2023 16:20, Krzysztof Kozlowski wrote: >> On 13/10/2023 11:30, Kris Chaplin wrote: >>> Add a master driver to support the AMD 1-Wire programmable logic IP block. >>> This block guarantees protocol timing for driving off-board devices such >>> as thermal sensors, proms, etc. >>> >>> Add file to MAINTAINERS >>> >>> Co-developed-by: Thomas Delev <thomas.delev@xxxxxxx> >>> Signed-off-by: Thomas Delev <thomas.delev@xxxxxxx> >>> Signed-off-by: Kris Chaplin <kris.chaplin@xxxxxxx> >>> --- >>> MAINTAINERS | 1 + >>> drivers/w1/masters/Kconfig | 11 + >>> drivers/w1/masters/Makefile | 1 + >>> drivers/w1/masters/amd_w1.c | 422 ++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 435 insertions(+) >>> create mode 100644 drivers/w1/masters/amd_w1.c >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 6ec3922b256e..7f26dab5261b 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -1072,6 +1072,7 @@ R: Thomas Delev <thomas.delev@xxxxxxx> >>> R: Michal Simek <michal.simek@xxxxxxx> >>> S: Maintained >>> F: Documentation/devicetree/bindings/w1/amd,axi-1wire-master.yaml >>> +F: drivers/w1/masters/amd_w1.c >>> >>> AMD XGBE DRIVER >>> M: "Shyam Sundar S K" <Shyam-sundar.S-k@xxxxxxx> >>> diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig >>> index ad316573288a..9232fd1f4e5b 100644 >>> --- a/drivers/w1/masters/Kconfig >>> +++ b/drivers/w1/masters/Kconfig >>> @@ -67,5 +67,16 @@ config W1_MASTER_SGI >>> This support is also available as a module. If so, the module >>> will be called sgi_w1. >>> >>> +config W1_MASTER_AMD >> This looks oddly places. Isn't entry above 'S', so A should go before? >> The rule is for entire Linux kernel: do not stuff things to the end of >> the lists. > There doesnt appear to be a specific alphabetical ordering taking place > in this Kconfig: > > config W1_MASTER_MATROX > config W1_MASTER_DS2490 > config W1_MASTER_DS2482 > config W1_MASTER_MXC > config W1_MASTER_GPIO > config HDQ_MASTER_OMAP > config W1_MASTER_SGI > config W1_MASTER_AMD I understand, happens. Still stuff should not be added to the end of lists. Best regards, Krzysztof
