On 10/12/2023 10:32 PM, Krishna Kurapati PSSNV wrote:
On 10/12/2023 10:10 PM, Konrad Dybcio wrote:
On 10/7/23 17:48, Krishna Kurapati wrote:
Add USB and DWC3 node for tertiary port of SC8280 along with multiport
IRQ's and phy's. This will be used as a base for SA8295P and SA8295-Ride
platforms.
Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
---
[...]
+
+ interconnects = <&aggre1_noc MASTER_USB3_MP 0 &mc_virt
SLAVE_EBI1 0>,
+ <&gem_noc MASTER_APPSS_PROC 0 &config_noc
SLAVE_USB3_MP 0>;
Please use QCOM_ICC_TAG_ALWAYS from
include/dt-bindings/interconnect/qcom,icc.h (like in sa8775p)
With that I think it's good to go :)
Hi Konrad. Thanks for the review.
I see that the tags are used fr spi/i2c but not usb. So to maintain
uniformity, wanted to keep the same here.
Hi Konrad,
Even in sa8775p.dtsi, the interconnect nodes have 0 & 1 instead of
macros. So wouldn't it be disturbing the uniformity if we use ICC_TAG's
here. Let me know your thoughts on this.
Regards,
Krishna,
