On 17/10/2023 19:46, Krishna Kurapati PSSNV wrote: > > > On 10/17/2023 10:49 PM, Krzysztof Kozlowski wrote: >> On 17/10/2023 15:18, Krishna Kurapati wrote: >>> Add enable-rt binding to let the device register vendor hooks to >>> core and facilitate runtime suspend and resume. >>> >>> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >>> index cb50261c6a36..788d9c510abc 100644 >>> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >>> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >>> @@ -151,6 +151,11 @@ properties: >>> HS/FS/LS modes are supported. >>> type: boolean >>> >>> + qcom,enable-rt: >>> + description: >>> + If present, register vendor hooks to facilitate runtime suspend/resume >> >> You described the desired Linux feature or behavior, not the actual >> hardware. The bindings are about the latter, so instead you need to >> rephrase the property and its description to match actual hardware >> capabilities/features/configuration etc. >> > > Hi Krzysztof, > > Thanks for the review. Although it sounds like its a Linux property, > internally what it does is configuring qscratch registers properly when > (dr_mode == OTG) That's not what you wrote. You wrote "register vendor hooks". Really, this is nothing to do with hardware. > > Would it be fine to rephrase the property name to > "qcom,config-qscratch" and to make it dependent on dr_mode and > usb-role-switch properties ? Would it be possible to make such a > dependency in bindings ? Examples are in: example-schema or my talk. Best regards, Krzysztof
