Re: [PATCH 5/5] arm64: dts: qcom: sm8350-lemonade(p): new devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/10/2023 23:41, Nia Espera wrote:


>>> +
>>> +&i2c4 {
>>> +	touchscreen@48 {
>>> +		compatible = "samsung,s6sy761";
>>> +		reg = <0x48>;
>>> +		interrupts-extended = <&tlmm 23 0x2008>;
>>
>> Replace the 0x2008 with the GPIO_* flags from include/dt-bindings/gpio/gpio.h
> 
> There doesn't seem to be a flag for 0x2000 and it's not documented 
> downstream; is it okay to replace with (0x2000|GPIO_TRANSITORY)?

Not gpio.h but irq.h. I don't think TLMM supports 2008 as a flag. This
looks wrong.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux