On Tue, Jan 6, 2015 at 9:29 AM, Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx> wrote: > From: Phani Movva <Phani.Movva@xxxxxxxxxx> > > Add the devicetree binding document for Cosmic Circuits 10001 ADC device. > > Signed-off-by: Phani Movva <Phani.Movva@xxxxxxxxxx> > Signed-off-by: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx> > [Ezequiel: minor style cleaning] > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx> > --- > .../devicetree/bindings/iio/adc/cc10001_adc.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/cc10001_adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/cc10001_adc.txt b/Documentation/devicetree/bindings/iio/adc/cc10001_adc.txt > new file mode 100644 > index 0000000..b7ba558 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/cc10001_adc.txt > @@ -0,0 +1,22 @@ > +* Cosmic Circuits - Analog to Digital Converter (CC-10001-ADC) > + > +Required properties: > + - compatible: Should be "cosmic,10001-adc" > + - reg: Should contain adc registers location and length. > + - clock-names: Should contain "adc". > + - clocks: Should contain a clock specifier for each entry in clock-names > + - vref-supply: The regulator supply ADC reference voltage. > + > +Optional properties: > + - cosmic,adc-reserved-channels: Bitmask of reserved channels, > + i.e. channels that cannot be used by the OS. Seems like this could be pretty common for any ADC as well as having the number of channels, so you can drop the vendor prefix. Do we have any similar properties already in other drivers? I'd reverse the polarity to be enabled channels, then the number of available channels is the top set bit plus 1. You could count channels as is, but then people have to remember to set the high bits on non-existent channels. Absence of the property could still mean you know how many channels and all are enabled. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
