Hi Rob, On Wed, 11 Oct 2023 at 12:01, Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Wed, 11 Oct 2023 10:41:48 +0530, Anand Moon wrote: > > Add the binding example for the USB3.1 Genesys Logic GL3523 > > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > > hub. > > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > --- > > New patch. > > --- > > .../bindings/usb/genesys,gl850g.yaml | 28 +++++++++++++++++-- > > 1 file changed, 25 insertions(+), 3 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'reset-gpios' is a required property > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'vdd-supply' is a required property > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'peer-hub' is a required property > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-device.example.dtb: hub@1: 'reset-gpios' is a required property > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-device.example.dtb: hub@1: 'vdd-supply' is a required property > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-device.example.dtb: hub@1: 'peer-hub' is a required property > from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231011051152.133257-1-linux.amoon@xxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Can you share an example to add two examples in this binding? one for usb5e3,608 and other for usb5e3,610, usb5e3,620, I have tried but I got an error for duplicate I have tried to modify it with the following example +allOf: + - if: + properties: + compatible: + contains: + const: usb5e3,608 + then: + properties: + reset-gpios: true + vdd-supply: false + peer-hub: false + else: + $ref: usb-device.yaml + required: + - peer-hub but it still shows me his warning, DTC_CHK Documentation/devicetree/bindings/usb/usb-hcd.example.dtb /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'peer-hub' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# I could not find any binding which supports these properties. - reset-gpios - vdd-supply - peer-hub Please suggest to me how to resolve this warning. Thanks -Anand
