On Wed, Oct 11, 2023 at 07:03:44PM +0100, Peter Griffin wrote:
> Hi Greg,
>
> Thanks for the review.
>
> On Wed, 11 Oct 2023 at 08:47, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Oct 10, 2023 at 11:49:24PM +0100, Peter Griffin wrote:
> > > Add serial driver data for Google Tensor gs101 SoC.
> > >
> > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> > > ---
> > > drivers/tty/serial/samsung_tty.c | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> > >
> > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> > > index 07fb8a9dac63..79a1a184d5c1 100644
> > > --- a/drivers/tty/serial/samsung_tty.c
> > > +++ b/drivers/tty/serial/samsung_tty.c
> > > @@ -2597,14 +2597,21 @@ static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
> > > .fifosize = { 256, 64, 64, 64 },
> > > };
> > >
> > > +static const struct s3c24xx_serial_drv_data gs101_serial_drv_data = {
> > > + EXYNOS_COMMON_SERIAL_DRV_DATA(),
> > > + .fifosize = { 256, 64, 64, 64 },
> > > +};
> >
> > Why are you duplicating a structure that is already in the same file?
> > What is the benifit here?
>
> There is a mistake here, the struct shouldn't be the same as e850 it
> should look like this
>
> static const struct s3c24xx_serial_drv_data gs101_serial_drv_data = {
> EXYNOS_COMMON_SERIAL_DRV_DATA(),
> /* rely on samsung,uart-fifosize DT property for fifosize */
> .fifosize = { 0 },
> };
>
> This then allows the fifosize to be taken from the samsung,uart-fifosize
> DT property for each of the 19 UARTs on this SoC.
Ah, ok, then that makes more sense, and makes sense why you would want a
unique dt identifier for this device. Make that change and I'll be much
happier :)
thanks,
greg k-h
