On Tue, 10 Oct 2023 15:57:34 +0200 Anrew Lunn wrote: >On Tue, Oct 10, 2023 at 03:41:39PM +0200, Ante Knezic wrote: >> On Tue, 10 Oct 2023 15:25:44 +0200, Andrew Lunn wrote: >> >> + microchip,rmii-clk-internal: >> >> + $ref: /schemas/types.yaml#/definitions/flag >> >> + description: >> >> + Set if the RMII reference clock should be provided internally. Applies only >> >> + to KSZ88X3 devices. >> > >> >It would be good to define what happens when >> >microchip,rmii-clk-internal is not present. Looking at the code, you >> >leave it unchanged. Is that what we want, or do we want to force it to >> >external? >> > >> > Andrew >> >> Default register setting is to use external RMII clock (which is btw only >> available option for other KSZ devices - as far as I am aware) so I guess >> theres no need to force it to external clock? > >We just need to watch out for a bootloader setting it. Or is it really >guaranteed to be false, because the DSA driver always does a device reset, >removing all existing configuration? > >I prefer it is unambiguously documented what not having the property >means. > > Andrew The bootloader case might be a issue if the reset-gpio property is not defined for the switch. In this case we should probably enforce the value either way. I will do the changes and repost. Thanks for feedback, Ante
