On Tue, Oct 10, 2023 at 11:52:28AM +0300, Matti Vaittinen wrote: > On 10/8/23 18:48, Subhajit Ghosh wrote: > > Add devicetree bindings for Avago APDS9306 Ambient Light Sensor. > > > > Signed-off-by: Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> > > --- > > .../bindings/iio/light/avago,apds9306.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > > new file mode 100644 > > index 000000000000..e8bb897782fc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/light/avago,apds9306.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Avago APDS9306 Ambient Light Sensor > > + > > +maintainers: > > + - Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> > > + > > +description: > > + Datasheet at https://docs.broadcom.com/doc/AV02-4755EN > > + > > +properties: > > + compatible: > > + const: avago,apds9306 > > I see the driver supports two different variants of this IC, differentiated > by the part-ID register. Variants are named as apds9306 and apds9306-065. I > wonder if we could/should have different compatibles for them? If 1 compatible is sufficient to know how to power on both devices and read the part-ID register, then no need for different compatibles. Rob
