On Tue, Oct 10, 2023 at 02:56:56PM +0100, Bryan O'Donoghue wrote: > On 10/10/2023 14:25, Rob Herring wrote: > > > > On Tue, 10 Oct 2023 13:25:38 +0100, Bryan O'Donoghue wrote: > > > Add bindings for qcom,sc8280xp-camss in order to support the camera > > > subsystem for sc8280xp as found in the Lenovo x13s Laptop. > > > > > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > > > --- > > > .../bindings/media/qcom,sc8280xp-camss.yaml | 582 ++++++++++++++++++ > > > 1 file changed, 582 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.example.dts:26:18: fatal error: dt-bindings/clock/qcom,sc8280xp-camcc.h: No such file or directory > > 26 | #include <dt-bindings/clock/qcom,sc8280xp-camcc.h> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > I guess I should be embedding this > > > This patch depends-on: > https://lore.kernel.org/lkml/20231004161853.86382-2-bryan.odonoghue@xxxxxxxxxx/T/ > > or > > > This patch depends-on: > https://lore.kernel.org/lkml/20231004161853.86382-2-bryan.odonoghue@xxxxxxxxxx/T/#mc33be3fef01bffe892f72bd5e567dba6a047283b > > below the "---" in this patch directly, instead of in the series description > ? I preferred in the patch itself, but now it doesn't really matter as far as getting a report goes. They go out now without my review. So you get them faster, but I can't handle dependencies unless there's a standard way a script can. There's 'base-commit' but I don't think that's used enough to rely on and it doesn't work if the dependency is not yet applied and in linux-next. I'd still put the dependency here, so it's quoted in the report. Rob
