Hi, On Sun, Oct 8, 2023 at 12:33 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Sat, Oct 7, 2023 at 8:06 AM Cong Yang > <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > Linus series proposed to break out ili9882t as separate driver, > > but he didn't have time for that extensive rework of the driver. > > As discussed by Linus and Doug [1], keep macro using the "struct panel_init_cmd" > > until we get some resolution about the binary size issue. > > OK works for me: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Dough, if it looks OK to you too, can you apply the patches? Thanks for the review. I had a few small comments so I'd expect a v2. I suspect it would look a little weird to add your Reviewed-by to patch #1 since the way Cong has it you're the direct patch author. :-P Cong, I suspect you may want to change the tagging on patch #1. I'd suggest setting yourself as the patch author (git commit --amend --reset-author), then tag the first patch like this (I put "x-" first to make it obvious to any bots reading this that these are not tags to actually apply--remove that when you tag your patch): x-Co-developed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> x-Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> x-Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> x-Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> Also: just as a heads up, Hsin-Yi measured the impact of removing the "command table" for init and replacing it with a whole pile of direct function calls. She found that it added over 100K to the driver (!!!). I believe it went from a 45K driver to a 152K driver. Something to keep in mind. ;-) -Doug
