> > + mcu_watchdog1: watchdog@40610000 {
> > + compatible = "ti,j7-rti-wdt";
> > + reg = <0x00 0x40610000 0x00 0x100>;
> > + clocks = <&k3_clks 368 1>;
> > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>;
> > + assigned-clocks = <&k3_clks 368 0>;
> > + assigned-clock-parents = <&k3_clks 368 4>;
>
> Please DONOT ignore the review comments - I did ask the documentation in
> dts as well. reason being that this is what people will see rather than
> dig up the commit log. it should be intutive when reading the dts why
> nodes are disabled by default Vs the standard of leaving it enabled by
> default. Given esp that these peripherals do not have anything to do
> with board semantics (pinmux or something similar) to be complete.
>
> > + status = "disabled";
Just providing clarifying comment - something like this is probably more
appropriate:
/* Tightly coupled to R5F */
status = "reserved";
The rti needs to be handled by R5F and is reserved for firmware usage.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
