On Wed, Oct 4, 2023 at 11:11 AM Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote: > > Add the yaml bindings for Mobileye SoCs. Currently only EyeQ5 is > supported > > Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> > --- > .../devicetree/bindings/mips/mobileye.yaml | 36 +++++++++ > include/dt-bindings/soc/mobileye,eyeq5.h | 77 +++++++++++++++++++ > 2 files changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mips/mobileye.yaml > create mode 100644 include/dt-bindings/soc/mobileye,eyeq5.h > > diff --git a/Documentation/devicetree/bindings/mips/mobileye.yaml b/Documentation/devicetree/bindings/mips/mobileye.yaml > new file mode 100644 > index 000000000000..f47767bc2c8f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mips/mobileye.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause Use what checkpatch tells you. > +# Copyright 2023 Mobileye Vision Technologies Ltd. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mips/mobileye.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mobileye SoC series > + > +maintainers: > + - Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxx> > + - Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> > + - Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > + > +description: | Don't need '|'. > + Boards with a Mobileye SoC shall have the following properties. > + > +properties: > + $nodename: > + const: '/' > + > + compatible: > + oneOf: > + - description: Boards with Mobileye EyeQ5 SoC > + items: > + - enum: > + - mobileye,eyeq5-epm5 > + - const: mobileye,eyeq5 > + > + - description: Boards with Mobileye EyeQ6 SoC > + items: > + - const: mobileye,eyeq6 Not valid to have only SoC compatible. Add this when you have a user. > + > +additionalProperties: true > + > +... > diff --git a/include/dt-bindings/soc/mobileye,eyeq5.h b/include/dt-bindings/soc/mobileye,eyeq5.h > new file mode 100644 > index 000000000000..7d8cb97b45bf > --- /dev/null > +++ b/include/dt-bindings/soc/mobileye,eyeq5.h > @@ -0,0 +1,77 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright 2023 Mobileye Vision Technologies Ltd. > + */ > +#ifndef _DT_BINDINGS_SOC_MOBILEYE_EYEQ5_H > +#define _DT_BINDINGS_SOC_MOBILEYE_EYEQ5_H > + > +/* EQ5 interrupts */ > +#define NUM_INT_I2C_A 1 > +#define NUM_INT_I2C_B 2 > +#define NUM_INT_I2C_C 3 > +#define NUM_INT_I2C_D 4 > +#define NUM_INT_I2C_E 5 These are interrupt numbers? Note that we never do headers for interrupt numbers, so drop this. Rob