On 02/10/2023 16:10, Jerome Brunet wrote:
Add support for the Libretech cottonwood board family. These 2 boards are based on the same PCB, with an RPi B form factor. The "Alta" board uses an a311d while the "Solitude" variant uses an s905d3. Co-developed-by: Da Xue <da.xue@xxxxxxxxxxxx> Signed-off-by: Da Xue <da.xue@xxxxxxxxxxxx> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> --- arch/arm64/boot/dts/amlogic/Makefile | 2 + .../amlogic/meson-g12b-a311d-libretech-cc.dts | 133 ++++ .../amlogic/meson-libretech-cottonwood.dtsi | 610 ++++++++++++++++++ .../amlogic/meson-sm1-s905d3-libretech-cc.dts | 89 +++ 4 files changed, 834 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-a311d-libretech-cc.dts create mode 100644 arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-s905d3-libretech-cc.dts
<snip>
+ + leds-pwm { + compatible = "pwm-leds"; + + led-green { + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_STATUS; + linux,default-trigger = "default-on"; + panic-indicator; + max-brightness = <255>; + pwms = <&pwm_cd 1 1250 0>; + active-low; + }; + + led-blue { + color = <LED_COLOR_ID_BLUE>; + function = LED_FUNCTION_ACTIVITY; + linux,default-trigger = "activity";
"activity" isn't documented, perhaps heartbeat instead ?
+ max-brightness = <255>; + pwms = <&pwm_ab 1 1250 0>; + active-low; + };
leds subnodes should be named as led(-[0-9a-f]+) see Documentation/devicetree/bindings/leds/leds-pwm.yaml
+ }; + + leds-gpio { + compatible = "gpio-leds"; + + led-orange { + color = <LED_COLOR_ID_AMBER>; + function = LED_FUNCTION_STANDBY; + gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; + };
Ditto, but you can simply use "led" since it's the only one. See Documentation/devicetree/bindings/leds/leds-gpio.yaml Neil <snip>