Hi Shawn,
Thank you for the review.
@all - some of you have received this email including HTML,
this is attempted resend as plain text ...
Am 24.09.23 um 15:51 schrieb Shawn Guo:
On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index a750be13ace8..9448d2effd8a 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
Out of alphabetical order.
Ack.
+
+ led_sfp_at: led-sfp-at {
+ gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
+ default-state = "off";
+ };
Have a newline between nodes.
Ack.
+&i2c2 {
This label node seems out of alphabetical order.
Ack.
+&esdhc1 {
+ status = "okay";
+ bus-width = <8>;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
We usually have 'status' be the last property.
You are not the first to notice this, but somehow in each version I
forgot about changing it :(.
v6 will for sure put this status property in last place!
Shawn
sincerely
Josua Mayer
