Re: [PATCH 3/9] ARM: versatile: add DT based PCI detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tuesday 30 December 2014 13:28:32 Rob Herring wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
> 
> Disable the Versatile PCI DT node when no PCI backplane is detected. This
> will prevent the Versatile PCI driver from probing when PCI is not
> populated.

Can you explain why the check is done in platform code instead of the PCI
driver probe function itself?

> +	/* Check if PCI backplane is detected */
> +	val = __raw_readl(base + VERSATILE_SYS_PCICTL_OFFSET);
> +	if (val & 1)
> +		goto err;

Using __raw_readl prevents this from working with big-endian kernels, so just
use readl here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux