On 27/09/2023 12:54, Lucas Tanure wrote: > On Wed, Sep 27, 2023 at 8:48 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 27/09/2023 08:08, Lucas Tanure wrote: >>> On 22-09-2023 10:43, Huqiang Qin wrote: >>>> Add a new compatible name for Amlogic T7 pin controller, and add >>>> a new dt-binding header file which document the detail pin names. >>>> >>>> Signed-off-by: Huqiang Qin <huqiang.qin@xxxxxxxxxxx> >>>> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >>>> --- >>>> >>>> V1 -> V2: Rename amlogic-t7-gpio.h to amlogic,t7-periphs-pinctrl.h >>>> Corrected indentation format. >>>> V2 -> V3: Updated subject. >>>> >>>> .../pinctrl/amlogic,meson-pinctrl-a1.yaml | 1 + >>>> .../gpio/amlogic,t7-periphs-pinctrl.h | 179 ++++++++++++++++++ >> >> ... >> >>>> +#define GPIOH_0 148 >>>> +#define GPIOH_1 149 >>>> +#define GPIOH_2 150 >>>> +#define GPIOH_3 151 >>>> +#define GPIOH_4 152 >>>> +#define GPIOH_5 153 >>>> +#define GPIOH_6 154 >>>> +#define GPIOH_7 155 >>>> + >>>> +#define GPIO_TEST_N 156 >>>> + >>>> +#endif /* _DT_BINDINGS_AMLOGIC_T7_GPIO_H */ >>> Tested-by: Lucas Tanure <tanure@xxxxxxxxx> >> >> How can you test bindings? >> >> Best regards, >> Krzysztof >> > Sure! > make dt_binding_check dtbs_check don't flag any issues with T7 bindings. Rob's bot does it... anyway this is ehich is equivalent to compile testing of C. This is not testing and we do no credit compile tests with "Tested-by". Otherwise dozens of build-bots would had to receive it. Best regards, Krzysztof
